| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202312131922.5dJORQu4-lkp@intel.com>
Date: Wed, 13 Dec 2023 19:22:32 +0800
From: kernel test robot <lkp@...el.com>
To: Alexander Graf <graf@...zon.com>, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-trace-kernel@...r.kernel.org, linux-mm@...ck.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kexec@...ts.infradead.org, linux-doc@...r.kernel.org,
x86@...nel.org, Eric Biederman <ebiederm@...ssion.com>,
"H. Peter Anvin" <hpa@...or.com>,
Andy Lutomirski <luto@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Rob Herring <robh+dt@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Mark Rutland <mark.rutland@....com>,
Tom Lendacky <thomas.lendacky@....com>,
Ashish Kalra <ashish.kalra@....com>,
James Gowans <jgowans@...zon.com>,
Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
arnd@...db.de, pbonzini@...hat.com, madvenka@...ux.microsoft.com,
Anthony Yznaga <anthony.yznaga@...cle.com>,
Usama Arif <usama.arif@...edance.com>,
David Woodhouse <dwmw@...zon.co.uk>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH 08/15] tracing: Introduce names for ring buffers
Hi Alexander,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on arm64/for-next/core akpm-mm/mm-everything linus/master v6.7-rc5 next-20231213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Graf/mm-memblock-Add-support-for-scratch-memory/20231213-080941
base: tip/x86/core
patch link: https://lore.kernel.org/r/20231213000452.88295-9-graf%40amazon.com
patch subject: [PATCH 08/15] tracing: Introduce names for ring buffers
config: i386-buildonly-randconfig-003-20231213 (https://download.01.org/0day-ci/archive/20231213/202312131922.5dJORQu4-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231213/202312131922.5dJORQu4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312131922.5dJORQu4-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/trace/ring_buffer_benchmark.c:435:53: error: too few arguments provided to function-like macro invocation
buffer = ring_buffer_alloc(1000000, RB_FL_OVERWRITE);
^
include/linux/ring_buffer.h:96:9: note: macro 'ring_buffer_alloc' defined here
#define ring_buffer_alloc(name, size, flags) \
^
>> kernel/trace/ring_buffer_benchmark.c:435:11: error: use of undeclared identifier 'ring_buffer_alloc'; did you mean '__ring_buffer_alloc'?
buffer = ring_buffer_alloc(1000000, RB_FL_OVERWRITE);
^~~~~~~~~~~~~~~~~
__ring_buffer_alloc
include/linux/ring_buffer.h:88:1: note: '__ring_buffer_alloc' declared here
__ring_buffer_alloc(const char *name, unsigned long size, unsigned flags,
^
2 errors generated.
--
>> kernel/trace/ring_buffer.c:6096:65: error: too few arguments provided to function-like macro invocation
buffer = ring_buffer_alloc(RB_TEST_BUFFER_SIZE, RB_FL_OVERWRITE);
^
include/linux/ring_buffer.h:96:9: note: macro 'ring_buffer_alloc' defined here
#define ring_buffer_alloc(name, size, flags) \
^
>> kernel/trace/ring_buffer.c:6096:11: error: use of undeclared identifier 'ring_buffer_alloc'; did you mean '__ring_buffer_alloc'?
buffer = ring_buffer_alloc(RB_TEST_BUFFER_SIZE, RB_FL_OVERWRITE);
^~~~~~~~~~~~~~~~~
__ring_buffer_alloc
kernel/trace/ring_buffer.c:1873:19: note: '__ring_buffer_alloc' declared here
EXPORT_SYMBOL_GPL(__ring_buffer_alloc);
^
2 errors generated.
vim +435 kernel/trace/ring_buffer_benchmark.c
5092dbc96f3acd Steven Rostedt 2009-05-05 429
5092dbc96f3acd Steven Rostedt 2009-05-05 430 static int __init ring_buffer_benchmark_init(void)
5092dbc96f3acd Steven Rostedt 2009-05-05 431 {
5092dbc96f3acd Steven Rostedt 2009-05-05 432 int ret;
5092dbc96f3acd Steven Rostedt 2009-05-05 433
5092dbc96f3acd Steven Rostedt 2009-05-05 434 /* make a one meg buffer in overwite mode */
5092dbc96f3acd Steven Rostedt 2009-05-05 @435 buffer = ring_buffer_alloc(1000000, RB_FL_OVERWRITE);
5092dbc96f3acd Steven Rostedt 2009-05-05 436 if (!buffer)
5092dbc96f3acd Steven Rostedt 2009-05-05 437 return -ENOMEM;
5092dbc96f3acd Steven Rostedt 2009-05-05 438
5092dbc96f3acd Steven Rostedt 2009-05-05 439 if (!disable_reader) {
5092dbc96f3acd Steven Rostedt 2009-05-05 440 consumer = kthread_create(ring_buffer_consumer_thread,
5092dbc96f3acd Steven Rostedt 2009-05-05 441 NULL, "rb_consumer");
5092dbc96f3acd Steven Rostedt 2009-05-05 442 ret = PTR_ERR(consumer);
5092dbc96f3acd Steven Rostedt 2009-05-05 443 if (IS_ERR(consumer))
5092dbc96f3acd Steven Rostedt 2009-05-05 444 goto out_fail;
5092dbc96f3acd Steven Rostedt 2009-05-05 445 }
5092dbc96f3acd Steven Rostedt 2009-05-05 446
5092dbc96f3acd Steven Rostedt 2009-05-05 447 producer = kthread_run(ring_buffer_producer_thread,
5092dbc96f3acd Steven Rostedt 2009-05-05 448 NULL, "rb_producer");
5092dbc96f3acd Steven Rostedt 2009-05-05 449 ret = PTR_ERR(producer);
5092dbc96f3acd Steven Rostedt 2009-05-05 450
5092dbc96f3acd Steven Rostedt 2009-05-05 451 if (IS_ERR(producer))
5092dbc96f3acd Steven Rostedt 2009-05-05 452 goto out_kill;
5092dbc96f3acd Steven Rostedt 2009-05-05 453
98e4833ba3c314 Ingo Molnar 2009-11-23 454 /*
98e4833ba3c314 Ingo Molnar 2009-11-23 455 * Run them as low-prio background tasks by default:
98e4833ba3c314 Ingo Molnar 2009-11-23 456 */
7ac07434048001 Steven Rostedt 2009-11-25 457 if (!disable_reader) {
4fd5750af02ab7 Peter Zijlstra 2020-07-20 458 if (consumer_fifo >= 2)
4fd5750af02ab7 Peter Zijlstra 2020-07-20 459 sched_set_fifo(consumer);
4fd5750af02ab7 Peter Zijlstra 2020-07-20 460 else if (consumer_fifo == 1)
4fd5750af02ab7 Peter Zijlstra 2020-07-20 461 sched_set_fifo_low(consumer);
4fd5750af02ab7 Peter Zijlstra 2020-07-20 462 else
7ac07434048001 Steven Rostedt 2009-11-25 463 set_user_nice(consumer, consumer_nice);
7ac07434048001 Steven Rostedt 2009-11-25 464 }
7ac07434048001 Steven Rostedt 2009-11-25 465
4fd5750af02ab7 Peter Zijlstra 2020-07-20 466 if (producer_fifo >= 2)
4fd5750af02ab7 Peter Zijlstra 2020-07-20 467 sched_set_fifo(producer);
4fd5750af02ab7 Peter Zijlstra 2020-07-20 468 else if (producer_fifo == 1)
4fd5750af02ab7 Peter Zijlstra 2020-07-20 469 sched_set_fifo_low(producer);
4fd5750af02ab7 Peter Zijlstra 2020-07-20 470 else
7ac07434048001 Steven Rostedt 2009-11-25 471 set_user_nice(producer, producer_nice);
98e4833ba3c314 Ingo Molnar 2009-11-23 472
5092dbc96f3acd Steven Rostedt 2009-05-05 473 return 0;
5092dbc96f3acd Steven Rostedt 2009-05-05 474
5092dbc96f3acd Steven Rostedt 2009-05-05 475 out_kill:
5092dbc96f3acd Steven Rostedt 2009-05-05 476 if (consumer)
5092dbc96f3acd Steven Rostedt 2009-05-05 477 kthread_stop(consumer);
5092dbc96f3acd Steven Rostedt 2009-05-05 478
5092dbc96f3acd Steven Rostedt 2009-05-05 479 out_fail:
5092dbc96f3acd Steven Rostedt 2009-05-05 480 ring_buffer_free(buffer);
5092dbc96f3acd Steven Rostedt 2009-05-05 481 return ret;
5092dbc96f3acd Steven Rostedt 2009-05-05 482 }
5092dbc96f3acd Steven Rostedt 2009-05-05 483
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists