linux-kernel - Re: [PATCH] media: i2c: mt9m114: add CONFIG_COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1992d665-cb98-4190-bee3-e5629c7d0e8d@app.fastmail.com>
Date:   Wed, 13 Dec 2023 12:23:05 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
        "Sakari Ailus" <sakari.ailus@...ux.intel.com>
Cc:     "Arnd Bergmann" <arnd@...nel.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Jacopo Mondi" <jacopo.mondi@...asonboard.com>,
        "Hans Verkuil" <hverkuil-cisco@...all.nl>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Bill Wendling" <morbo@...gle.com>,
        "Justin Stitt" <justinstitt@...gle.com>,
        "Hans de Goede" <hdegoede@...hat.com>,
        "Tomi Valkeinen" <tomi.valkeinen@...asonboard.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] media: i2c: mt9m114: add CONFIG_COMMON_CLK dependency

On Wed, Dec 13, 2023, at 10:58, Laurent Pinchart wrote:
> On Wed, Dec 13, 2023 at 09:10:19AM +0000, Sakari Ailus wrote:
>> On Wed, Dec 13, 2023 at 09:39:01AM +0100, Arnd Bergmann wrote:
>> > On Wed, Dec 13, 2023, at 09:09, Sakari Ailus wrote:
>> 
>> The datasheet says the input clock range is between 6 MHz and 54 MHz. We
>> could check that, and return an error if it's not in the range. The rate is
>> needed for other reasons, too, and the sensor is unlikely to work if it's
>> (more than little) off.
>> 
>> I wonder if this could address the Clang 16 issue, too? I'd replace
>> udelay() with fsleep() in any case, and at the very least Clang should be
>> happy with this.
>
> I'm fine with both of those changes.

I verified that the build failure is solved by either one.
I would just do the fsleep() change in that case since that
is a sensible change regardless of the undefined behavior.

I'll send a v2.

     Arnd