linux-kernel - [RFC 0/2] PCI: acpiphp: workaround race between hotplug and SCSI_SCAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231213003614.1648343-1-imammedo@redhat.com>
Date:   Wed, 13 Dec 2023 01:36:12 +0100
From:   Igor Mammedov <imammedo@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     Dongli Zhang <dongli.zhang@...cle.com>, linux-acpi@...r.kernel.org,
        linux-pci@...r.kernel.org, imammedo@...hat.com, mst@...hat.com,
        rafael@...nel.org, lenb@...nel.org, bhelgaas@...gle.com,
        mika.westerberg@...ux.intel.com, boris.ostrovsky@...cle.com,
        joe.jin@...cle.com, stable@...r.kernel.org,
        Fiona Ebner <f.ebner@...xmox.com>,
        Thomas Lamprecht <t.lamprecht@...xmox.com>
Subject: [RFC 0/2] PCI: acpiphp: workaround race between hotplug and SCSI_SCAN_ASYNC job

Hacks to mask a race between HBA scan job and bridge re-configuration(s)
during hotplug. 

I don't like it a bit but it something that could be done quickly
and solves problems that were reported.

Other options to discuss/possibly more invasive:
 1: make sure pci_assign_unassigned_bridge_resources() doesn't reconfigure
    bridge if it's not necessary.
 2. make SCSI_SCAN_ASYNC job wait till hotplug is finished for all slots on
    the bridge or somehow restart the job if it fails
 3. any other ideas?


1st reported: https://lore.kernel.org/r/9eb669c0-d8f2-431d-a700-6da13053ae54@proxmox.com

CC: Dongli Zhang <dongli.zhang@...cle.com>
CC: linux-acpi@...r.kernel.org
CC: linux-pci@...r.kernel.org
CC: imammedo@...hat.com
CC: mst@...hat.com
CC: rafael@...nel.org
CC: lenb@...nel.org
CC: bhelgaas@...gle.com
CC: mika.westerberg@...ux.intel.com
CC: boris.ostrovsky@...cle.com
CC: joe.jin@...cle.com
CC: stable@...r.kernel.org
CC: linux-kernel@...r.kernel.org
CC: Fiona Ebner <f.ebner@...xmox.com>
CC: Thomas Lamprecht <t.lamprecht@...xmox.com>

Igor Mammedov (2):
  PCI: acpiphp: enable slot only if it hasn't been enabled already
  PCI: acpiphp: slowdown hotplug if hotplugging multiple devices at a
    time

 drivers/pci/hotplug/acpiphp_glue.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
2.39.3