linux-kernel - Re: [PATCH v1] ASoC: tas2562: remove tas2563 into driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2023 15:45:05 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Shenghao Ding <shenghao-ding@...com>
Cc:     broonie@...nel.org, conor+dt@...nel.org,
        krzysztof.kozlowski@...aro.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, lgirdwood@...il.com, perex@...ex.cz,
        pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
        linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
        liam.r.girdwood@...el.com, soyer@....hu, tiwai@...e.de,
        peeyush@...com, navada@...com
Subject: Re: [PATCH v1] ASoC: tas2562: remove tas2563 into driver

On Tue, Dec 12, 2023 at 01:08:31PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in separated driver code.

No objection from the code perspective. The Q is, what is the behaviour of the
current users? Imagine we have a used of this chip and this driver gets it
enumerated. Does it work? if so, this patch can not be applied right now.
Otherwise the commit message above is missing an elaboration of the case.

-- 
With Best Regards,
Andy Shevchenko