linux-kernel - Re: [PATCH net-next] net: dsa: dont use generic selftest strings for custom selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231214144751.1507-1-ante.knezic@helmholz.de>
Date:   Thu, 14 Dec 2023 15:47:51 +0100
From:   Ante Knezic <ante.knezic@...mholz.de>
To:     <olteanv@...il.com>
CC:     <andrew@...n.ch>, <ante.knezic@...mholz.de>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <f.fainelli@...il.com>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: dsa: dont use generic selftest strings for custom selftests

Indeed I do have a custom implementation for the mv88e6xxx chip, but its not
come to state to be posted because of test/chip specifics.

> I didn't notice when the selftest support was added that there is no
> implementation in DSA drivers of custom ds->ops->self_test(). Adding
> interfaces with no users is frowned upon, precisely because it doesn't
> show the big picture.

I was not aware of this, I apologize. If this is the case, perhaps this patch
should wait for the first custom self test implementation and be reposted as
a part of bigger series.

Thanks,
Ante