linux-kernel - Re: [syzbot] [mptcp?] WARNING in mptcp_check_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2023 16:18:27 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     syzbot <syzbot+5a01c3a666e726bc8752@...kaller.appspotmail.com>,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org, martineau@...nel.org,
        matttbe@...nel.org, mptcp@...ts.linux.dev, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [mptcp?] WARNING in mptcp_check_listen_stop

On Wed, 2023-12-13 at 10:53 -0800, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    2513974cc3e1 Merge branch 'stmmac-bug-fixes'
> git tree:       net
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=116337fae80000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=b50bd31249191be8
> dashboard link: https://syzkaller.appspot.com/bug?extid=5a01c3a666e726bc8752
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1119061ee80000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=110ca006e80000

It looks like tcp_diag_destroy is closing the listener subflow, while
the mptcp stack is not expecting anyone to touch it while in listener
status. I guess we can relax the mptcp_check_listen_stop checks.

/P