linux-kernel - Re: [PATCH 2/3] bindings: hwmon: Add adi,adaq4224

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9ccf7ba-42e6-4ec6-9de9-51802e968de9@roeck-us.net>
Date:   Thu, 14 Dec 2023 07:15:13 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Matyas <daniel.matyas@...log.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/3] bindings: hwmon: Add adi,adaq4224_temp as compatible
 string

On 12/14/23 06:36, Daniel Matyas wrote:
> In the device ada4224 the max31827 temperature sensor will be used, so
> the default values corresponding to adaq4224_temp are the same for
> max31827.
> 

I don't know what that device is, but if the max31827 is used it should
be instantiated as max31827.

Guenter

> Signed-off-by: Daniel Matyas <daniel.matyas@...log.com>
> ---
>   Documentation/devicetree/bindings/hwmon/adi,max31827.yaml | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> index f60e06ab7d0a..9f3b0839aa46 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> @@ -20,6 +20,7 @@ properties:
>         - const: adi,max31827
>         - items:
>             - enum:
> +              - adi,adaq4224_temp
>                 - adi,max31828
>                 - adi,max31829
>             - const: adi,max31827
> @@ -81,7 +82,9 @@ allOf:
>         properties:
>           compatible:
>             contains:
> -            const: adi,max31827
> +            enum:
> +              - adi,max31827
> +              - adi,adaq4224_temp
>   
>       then:
>         properties: