linux-kernel - RE: [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYBPR01MB53415F2C51CB51A0ADFBD278D88CA@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date:   Thu, 14 Dec 2023 02:28:12 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>
CC:     Marek Vasut <marek.vasut+renesas@...il.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h
 include

Hello,

> From: Krzysztof Wilczyński, Sent: Thursday, December 14, 2023 10:33 AM
> 
> Hello,
> 
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it was merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> 
> Applied to controller/rcar, thank you!
> 
> [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=263714f5fcf8

Thank you! I completely overlooked this patch. Maybe it's too late, but I also reviewed this patch, so

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

It's up to you whether my tag is added to the commit or not :)

Best regards,
Yoshihiro Shimoda

> 	Krzysztof