linux-kernel - Re: [PATCH 11/13] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPLW+4nTgam4jZ+s5m5E05jWO_kfSy=fMS0Ywp3yQEEn-UESbg@mail.gmail.com>
Date:   Thu, 14 Dec 2023 09:55:03 -0600
From:   Sam Protsenko <semen.protsenko@...aro.org>
To:     Tudor Ambarus <tudor.ambarus@...aro.org>,
        krzysztof.kozlowski+dt@...aro.org
Cc:     peter.griffin@...aro.org, robh+dt@...nel.org,
        mturquette@...libre.com, sboyd@...nel.org, conor+dt@...nel.org,
        andi.shyti@...nel.org, alim.akhtar@...sung.com,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        catalin.marinas@....com, will@...nel.org, s.nawrocki@...sung.com,
        tomasz.figa@...il.com, cw00.choi@...sung.com, arnd@...db.de,
        andre.draszik@...aro.org, saravanak@...gle.com,
        willmcvicker@...gle.com, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 11/13] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole

On Thu, Dec 14, 2023 at 4:53 AM Tudor Ambarus <tudor.ambarus@...aro.org> wrote:
>
> Enable the eeprom found on the battery connector.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
>  .../boot/dts/exynos/google/gs101-oriole.dts    | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 4a71f752200d..11b299d21c5d 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -63,6 +63,19 @@ &ext_200m {
>         clock-frequency = <200000000>;
>  };
>
> +&hsi2c_8 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&hsi2c8_bus>;
> +       #address-cells = <1>;
> +       #size-cells = <0>;

Not sure if those 4 above properties belong in board's dts or in SoC's
dtsi. Krzysztof, what do you think?

Other than that:

Reviewed-by: Sam Protsenko <semen.protsenko@...aro.org>

> +       status = "okay";
> +
> +       eeprom: eeprom@50 {
> +               compatible = "atmel,24c08";
> +               reg = <0x50>;
> +       };
> +};
> +
>  &pinctrl_far_alive {
>         key_voldown: key-voldown-pins {
>                 samsung,pins = "gpa7-3";
> @@ -99,6 +112,11 @@ &usi_uart {
>         status = "okay";
>  };
>
> +&usi8 {
> +       samsung,mode = <USI_V2_I2C>;
> +       status = "okay";
> +};
> +
>  &watchdog_cl0 {
>         timeout-sec = <30>;
>         status = "okay";
> --
> 2.43.0.472.g3155946c3a-goog
>