linux-kernel - Re: [PATCH] igb: Add null pointer check to igb_set_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9250b0e9-360d-447d-b4bf-30e4bc4f697c@kylinos.cn>
Date:   Thu, 14 Dec 2023 10:44:35 +0800
From:   Kunwu Chan <chentao@...inos.cn>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        jacob.e.keller@...el.com, przemyslaw.kitszel@...el.com,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kunwu Chan <kunwu.chan@...mail.com>
Subject: Re: [PATCH] igb: Add null pointer check to igb_set_fw_version

Thanks for your reply.

I'll try to use snprintf in v2 patch.


On 2023/12/13 05:26, Jakub Kicinski wrote:
> On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote:
>> kasprintf() returns a pointer to dynamically allocated memory
>> which can be NULL upon failure.
>>
>> Fixes: 1978d3ead82c ("intel: fix string truncation warnings")
>> Cc: Kunwu Chan <kunwu.chan@...mail.com>
>> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> 
> The allocation is rather pointless here.
> Can you convert this code to use snprintf() instead?