linux-kernel - Re: [PATCH net-next v5 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18c695b4512.5afde007311004.1718468931473736202@siddh.me>
Date:   Thu, 14 Dec 2023 22:53:58 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Suman Ghosh" <sumang@...vell.com>,
        "netdev" <netdev@...r.kernel.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "syzbot+bbe84a4010eeea00982d" 
        <syzbot+bbe84a4010eeea00982d@...kaller.appspotmail.com>
Subject: Re: [PATCH net-next v5 1/2] nfc: llcp_core: Hold a ref to
 llcp_local->dev when holding a ref to llcp_local

On Wed, 13 Dec 2023 13:10:16 +0530, Krzysztof Kozlowski wrote:
> > -	if (sk_acceptq_is_full(parent)) {
> > -		reason = LLCP_DM_REJ;
> > -		release_sock(&sock->sk);
> > -		sock_put(&sock->sk);
> > -		goto fail;
> > -	}
> > +	if (sk_acceptq_is_full(parent))
> > +		goto fail_put_sock;
> 
> I would argue that you reshuffle here more code than needed for the fix.
> 
> This should fix only missing dev reference, not reshuffle code. It's a
> bugfix, not cleanup.

So this should not be done? I did it because you told to extend the
cleanup label in v3 discussion.

Thanks,
Siddh