linux-kernel - Re: [PATCH v6] zswap: memcontrol: implement zswap writeback disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAF8kJuMLDOaP6-Xyz-+hzLbDuYW7gfG9jA06j6t5v7XX2rPOdw@mail.gmail.com>
Date: Thu, 14 Dec 2023 15:22:27 -0800
From: Chris Li <chrisl@...nel.org>
To: Fabian Deutsch <fdeutsch@...hat.com>
Cc: Yu Zhao <yuzhao@...gle.com>, Johannes Weiner <hannes@...xchg.org>, 
	Minchan Kim <minchan@...nel.org>, Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org, 
	tj@...nel.org, lizefan.x@...edance.com, cerasuolodomenico@...il.com, 
	yosryahmed@...gle.com, sjenning@...hat.com, ddstreet@...e.org, 
	vitaly.wool@...sulko.com, mhocko@...nel.org, roman.gushchin@...ux.dev, 
	shakeelb@...gle.com, muchun.song@...ux.dev, hughd@...gle.com, corbet@....net, 
	konrad.wilk@...cle.com, senozhatsky@...omium.org, rppt@...nel.org, 
	linux-mm@...ck.org, kernel-team@...a.com, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, david@...t.cz, Kairui Song <kasong@...cent.com>, 
	Zhongkun He <hezhongkun.hzk@...edance.com>
Subject: Re: [PATCH v6] zswap: memcontrol: implement zswap writeback disabling

Hi Fabian,

On Thu, Dec 14, 2023 at 10:00 AM Fabian Deutsch <fdeutsch@...hat.com> wrote:

> Yep - for container use-cases.
>
> Now a few thoughts in this direction:
> - With swap per cgroup you loose the big "statistical" benefit of having swap on a node level. well, it depends on the size of the cgroup (i.e. system.slice is quite large).

Just to clarify, the "node" you mean the "node" in kubernetes sense,
which is the whole machine. In the Linux kernel MM context, the node
often refers to the NUMA memory node, that is not what you mean here,
right?

> - With todays node level swap, and setting memory.swap.max=0 for all cgroups allows you toachieve a similar behavior (only opt-in cgroups will get swap).
> - the above approach however will still have a shared swap backend for all cgroups.

Yes, the "memory.swap.tires" idea is trying to allow cgroups to select
a subset of the swap backend in a specific order. It is still in the
early stage of discussion. If you have any suggestion or feedback in
that direction, I am looking forward to hearing that.

Chris