linux-kernel - arch/arm/mm/init.c:718: warning: Function parameter or member 'perms' not described in 'update_sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202312150743.bwMvCOJ8-lkp@intel.com>
Date: Fri, 15 Dec 2023 07:48:24 +0800
From: kernel test robot <lkp@...el.com>
To: Grygorii Strashko <grygorii.strashko@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Russell King <rmk+kernel@...linux.org.uk>
Subject: arch/arm/mm/init.c:718: warning: Function parameter or member
 'perms' not described in 'update_sections_early'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c7402612e2e61b76177f22e6e7f705adcbecc6fe
commit: 11ce4b33aedc65198d7bc9669344ebca5ee36a41 ARM: 8672/1: mm: remove tasklist locking from update_sections_early()
date:   7 years ago
config: arm-s3c6400_defconfig (https://download.01.org/0day-ci/archive/20231215/202312150743.bwMvCOJ8-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231215/202312150743.bwMvCOJ8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312150743.bwMvCOJ8-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/arm/mm/init.c:128:13: warning: no previous prototype for 'setup_dma_zone' [-Wmissing-prototypes]
     128 | void __init setup_dma_zone(const struct machine_desc *mdesc)
         |             ^~~~~~~~~~~~~~
   arch/arm/mm/init.c:769:6: warning: no previous prototype for 'free_tcmmem' [-Wmissing-prototypes]
     769 | void free_tcmmem(void)
         |      ^~~~~~~~~~~
>> arch/arm/mm/init.c:718: warning: Function parameter or member 'perms' not described in 'update_sections_early'
>> arch/arm/mm/init.c:718: warning: Function parameter or member 'n' not described in 'update_sections_early'


vim +718 arch/arm/mm/init.c

1e6b48116a9504 Kees Cook         2014-04-03  711  
11ce4b33aedc65 Grygorii Strashko 2017-04-25  712  /**
11ce4b33aedc65 Grygorii Strashko 2017-04-25  713   * update_sections_early intended to be called only through stop_machine
11ce4b33aedc65 Grygorii Strashko 2017-04-25  714   * framework and executed by only one CPU while all other CPUs will spin and
11ce4b33aedc65 Grygorii Strashko 2017-04-25  715   * wait, so no locking is required in this function.
11ce4b33aedc65 Grygorii Strashko 2017-04-25  716   */
08925c2f124f1b Laura Abbott      2015-11-30  717  static void update_sections_early(struct section_perm perms[], int n)
1e6b48116a9504 Kees Cook         2014-04-03 @718  {
08925c2f124f1b Laura Abbott      2015-11-30  719  	struct task_struct *t, *s;
08925c2f124f1b Laura Abbott      2015-11-30  720  
08925c2f124f1b Laura Abbott      2015-11-30  721  	for_each_process(t) {
08925c2f124f1b Laura Abbott      2015-11-30  722  		if (t->flags & PF_KTHREAD)
08925c2f124f1b Laura Abbott      2015-11-30  723  			continue;
08925c2f124f1b Laura Abbott      2015-11-30  724  		for_each_thread(t, s)
08925c2f124f1b Laura Abbott      2015-11-30  725  			set_section_perms(perms, n, true, s->mm);
08925c2f124f1b Laura Abbott      2015-11-30  726  	}
08925c2f124f1b Laura Abbott      2015-11-30  727  	set_section_perms(perms, n, true, current->active_mm);
08925c2f124f1b Laura Abbott      2015-11-30  728  	set_section_perms(perms, n, true, &init_mm);
08925c2f124f1b Laura Abbott      2015-11-30  729  }
08925c2f124f1b Laura Abbott      2015-11-30  730  

:::::: The code at line 718 was first introduced by commit
:::::: 1e6b48116a95046ec51f3d40f83aff8b006674d7 ARM: mm: allow non-text sections to be non-executable

:::::: TO: Kees Cook <keescook@...omium.org>
:::::: CC: Kees Cook <keescook@...omium.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki