[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <170205513099.1790765.10945483067909366845.b4-ty@oracle.com>
Date: Wed, 13 Dec 2023 23:29:13 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Tyrel Datwyler <tyreld@...ux.ibm.com>,
Michael Ellerman <mpe@...erman.id.au>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
Justin Stitt <justinstitt@...gle.com>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
linux-scsi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: ibmvscsi: replace deprecated strncpy with strscpy
On Mon, 30 Oct 2023 20:40:48 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect partition_name to be NUL-terminated based on its usage with
> format strings:
> | dev_info(hostdata->dev, "host srp version: %s, "
> | "host partition %s (%d), OS %d, max io %u\n",
> | hostdata->madapter_info.srp_version,
> | hostdata->madapter_info.partition_name,
> | be32_to_cpu(hostdata->madapter_info.partition_number),
> | be32_to_cpu(hostdata->madapter_info.os_type),
> | be32_to_cpu(hostdata->madapter_info.port_max_txu[0]));
> ...
> | len = snprintf(buf, PAGE_SIZE, "%s\n",
> | hostdata->madapter_info.partition_name);
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: replace deprecated strncpy with strscpy
https://git.kernel.org/mkp/scsi/c/712b3f43ba0e
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists