linux-kernel - Re: linux-next: Tree for Dec 11 (riscv32: patch.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHVXubhN3GQ1hu7uVof2RSByVzAGCeT_-_YvNpgaDOKuZL2fBw@mail.gmail.com>
Date:   Thu, 14 Dec 2023 11:05:46 +0100
From:   Alexandre Ghiti <alexghiti@...osinc.com>
To:     Conor Dooley <conor@...nel.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        Palmer Dabbelt <palmer@...belt.com>
Subject: Re: linux-next: Tree for Dec 11 (riscv32: patch.c)

On Wed, Dec 13, 2023 at 2:33 PM Alexandre Ghiti <alexghiti@...osinc.com> wrote:
>
> On Wed, Dec 13, 2023 at 1:57 PM Conor Dooley <conor@...nel.org> wrote:
> >
> > On Tue, Dec 12, 2023 at 09:01:17AM +0100, Alexandre Ghiti wrote:
> > > Hi Randy,
> > >
> > > On Mon, Dec 11, 2023 at 10:17 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> > > >
> > > >
> > > >
> > > > On 12/10/23 22:25, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Changes since 20231208:
> > > > >
> > > >
> > > > on riscv32:
> > > >
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
> > > > patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
> > > > patch.c:(.text+0xd2): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
> > > > patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
> > > > patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
> > > > patch.c:(.text+0x202): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
> > > > patch.c:(.text+0x410): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
> > > > patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
> > > > patch.c:(.text+0x550): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
> > > >
> > > >
> > > > Full randconfig file is attached.
> > >
> > > We can ignore this one as CONFIG_XIP is enabled and we agreed at LPC
> > > that I'll remove this soon.
> >
> > I don't think we can (even if people hadn't sent patches yesterday for
> > XIP) act as if XIP being removed is a foregone conclusion.
>
> Ok, the fix is easy enough for me to send it right now, so I'll fix that :)

The fix is here
https://patchwork.kernel.org/project/linux-riscv/patch/20231214091926.203439-1-alexghiti@rivosinc.com/
and I asked Palmer to replace the v1 he already had in -fixes with
this new version, hopefully it will land in rc6.

Thanks,

Alex