linux-kernel - Re: [PATCH v7 20/24] x86/resctrl: Add CPU online callback for resctrl work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbecf6f1-4d51-c61d-a092-a85f9ab464ea@arm.com>
Date:   Thu, 14 Dec 2023 11:38:22 +0000
From:   James Morse <james.morse@....com>
To:     babu.moger@....com, x86@...nel.org, linux-kernel@...r.kernel.org
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        H Peter Anvin <hpa@...or.com>,
        shameerali.kolothum.thodi@...wei.com,
        D Scott Phillips OS <scott@...amperecomputing.com>,
        carl@...amperecomputing.com, lcherian@...vell.com,
        bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
        baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
        Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
        dfustini@...libre.com, amitsinght@...vell.com
Subject: Re: [PATCH v7 20/24] x86/resctrl: Add CPU online callback for resctrl
 work

Hi Babu,

On 09/11/2023 20:51, Moger, Babu wrote:
> On 10/25/23 13:03, James Morse wrote:
>> The resctrl architecture specific code may need to create a domain when
>> a CPU comes online, it also needs to reset the CPUs PQR_ASSOC register.
>> The resctrl filesystem code needs to update the rdtgroup_default CPU
>> mask when CPUs are brought online.
>>
>> Currently this is all done in one function, resctrl_online_cpu().
>> This will need to be split into architecture and filesystem parts
>> before resctrl can be moved to /fs/.
>>
>> Pull the rdtgroup_default update work out as a filesystem specific
>> cpu_online helper. resctrl_online_cpu() is the obvious name for this,
>> which means the version in core.c needs renaming.
>>
>> resctrl_online_cpu() is called by the arch code once it has done the
>> work to add the new CPU to any domains.
>>
>> In future patches, resctrl_online_cpu() will take the rdtgroup_mutex
>> itself.

> Reviewed-by: Babu Moger <babu.moger@....com>

Thanks!


James