linux-kernel - Re: [PATCH v1 4/9] staging: media: starfive: camss: Replace format index with pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231214121233.GB21146@pendragon.ideasonboard.com>
Date:   Thu, 14 Dec 2023 14:12:33 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Changhuang Liang <changhuang.liang@...rfivetech.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Marvin Lin <milkfafa@...il.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Ming Qian <ming.qian@....com>,
        Nicolas Dufresne <nicolas.dufresne@...labora.com>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>,
        Mingjia Zhang <mingjia.zhang@...iatek.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Jack Zhu <jack.zhu@...rfivetech.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v1 4/9] staging: media: starfive: camss: Replace format
 index with pad

Hi Changhuang,

Thank you for the patch.

On Wed, Dec 13, 2023 at 10:50:22PM -0800, Changhuang Liang wrote:
> Replace format index with pad.

The code change looks good I think, but the commit message needs to
explain *why* you're changing this.

> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> ---
>  drivers/staging/media/starfive/camss/stf-isp.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/media/starfive/camss/stf-isp.c b/drivers/staging/media/starfive/camss/stf-isp.c
> index ac83f23842df..c3ae02cf6dd8 100644
> --- a/drivers/staging/media/starfive/camss/stf-isp.c
> +++ b/drivers/staging/media/starfive/camss/stf-isp.c
> @@ -11,9 +11,6 @@
>  
>  #include "stf-camss.h"
>  
> -#define SINK_FORMATS_INDEX	0
> -#define SOURCE_FORMATS_INDEX	1
> -
>  static int isp_set_selection(struct v4l2_subdev *sd,
>  			     struct v4l2_subdev_state *state,
>  			     struct v4l2_subdev_selection *sel);
> @@ -95,11 +92,7 @@ static void isp_try_format(struct stf_isp_dev *isp_dev,
>  		return;
>  	}
>  
> -	if (pad == STF_ISP_PAD_SINK)
> -		formats = &isp_dev->formats[SINK_FORMATS_INDEX];
> -	else if (pad == STF_ISP_PAD_SRC)
> -		formats = &isp_dev->formats[SOURCE_FORMATS_INDEX];
> -
> +	formats = &isp_dev->formats[pad];
>  	fmt->width = clamp_t(u32, fmt->width, STFCAMSS_FRAME_MIN_WIDTH,
>  			     STFCAMSS_FRAME_MAX_WIDTH);
>  	fmt->height = clamp_t(u32, fmt->height, STFCAMSS_FRAME_MIN_HEIGHT,
> @@ -124,7 +117,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
>  		if (code->index >= ARRAY_SIZE(isp_formats_sink))
>  			return -EINVAL;
>  
> -		formats = &isp_dev->formats[SINK_FORMATS_INDEX];
> +		formats = &isp_dev->formats[code->pad];
>  		code->code = formats->fmts[code->index].code;
>  	} else {
>  		struct v4l2_mbus_framefmt *sink_fmt;

-- 
Regards,

Laurent Pinchart