linux-kernel - RE: [PATCH net-next v14 01/13] rtase: Add pci table supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8d5a54286e242f6a2caa5ffd7c1a6f3@realtek.com>
Date:   Thu, 14 Dec 2023 12:42:57 +0000
From:   JustinLai0215 <justinlai0215@...ltek.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Larry Chiu <larry.chiu@...ltek.com>
Subject: RE: [PATCH net-next v14 01/13] rtase: Add pci table supported in this module



> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Tuesday, December 12, 2023 5:36 PM
> To: JustinLai0215 <justinlai0215@...ltek.com>; kuba@...nel.org
> Cc: davem@...emloft.net; edumazet@...gle.com;
> linux-kernel@...r.kernel.org; netdev@...r.kernel.org; andrew@...n.ch;
> Ping-Ke Shih <pkshih@...ltek.com>; Larry Chiu <larry.chiu@...ltek.com>
> Subject: Re: [PATCH net-next v14 01/13] rtase: Add pci table supported in this
> module
> 
> 
> External mail.
> 
> 
> 
> On Fri, 2023-12-08 at 17:47 +0800, Justin Lai wrote:
> [...]
> > +static void rtase_remove_one(struct pci_dev *pdev) {
> > +     struct net_device *dev = pci_get_drvdata(pdev);
> > +     struct rtase_private *tp = netdev_priv(dev);
> > +     struct rtase_int_vector *ivec;
> > +     u32 i;
> > +
> > +     for (i = 0; i < tp->int_nums; i++) {
> > +             ivec = &tp->int_vector[i];
> > +             netif_napi_del(&ivec->napi);
> > +     }
> 
> You must unregister the netdev before napi_del or you will risk races.

Ok, Thank you for your suggestion.

> 
> Cheers,
> 
> Paolo