lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1556d890fac61e36b9546c5f520faa15e449bd55.camel@infradead.org>
Date:   Thu, 14 Dec 2023 13:41:49 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Paul Durrant <paul@....org>, Paolo Bonzini <pbonzini@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, Shuah Khan <shuah@...nel.org>,
        kvm@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v10 09/19] KVM: xen: separate initialization of
 shared_info cache and content

On Mon, 2023-12-04 at 14:43 +0000, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@...zon.com>
> 
> A subsequent patch will allow shared_info to be initialized using either a
> GPA or a user-space (i.e. VMM) HVA. To make that patch cleaner, separate
> the initialization of the shared_info content from the activation of the
> pfncache.
> 
> Signed-off-by: Paul Durrant <pdurrant@...zon.com>


Spot the difference...
 
> -               /*
> -                * This code mirrors kvm_write_wall_clock() except that it writes
> -                * directly through the pfn cache and doesn't mark the page dirty.
> -                */
> -               wall_nsec = kvm_get_wall_clock_epoch(kvm);


> +       /*
> +        * This code mirrors kvm_write_wall_clock() except that it writes
> +        * directly through the pfn cache and doesn't mark the page dirty.
> +        */
> +       wall_nsec = ktime_get_real_ns() - get_kvmclock_ns(kvm);

(Hint: it's commit 5d6d6a7d7e66a)

With that fixed,

Reviewed-by: David Woodhouse <dwmw@...zon.co.uk>


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ