linux-kernel - Re: [PATCH v5 21/22] MIPS: generic: Add support for Mobileye EyeQ5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875y0zcssc.fsf@BL-laptop>
Date: Fri, 15 Dec 2023 17:52:19 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Jiaxun Yang <jiaxun.yang@...goat.com>, "paulburton@...nel.org"
 <paulburton@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, Tawfik Bayouk
 <tawfik.bayouk@...ileye.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Théo Lebrun
 <theo.lebrun@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v5 21/22] MIPS: generic: Add support for Mobileye EyeQ5

"Jiaxun Yang" <jiaxun.yang@...goat.com> writes:

> 在2023年12月12日十二月 下午4:34，Gregory CLEMENT写道：
>> Introduce support for the MIPS based Mobileye EyeQ5 SoCs.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
>> ---
>>  arch/mips/configs/generic/board-eyeq5.config | 42 ++++++++++++++++++++
>>  arch/mips/generic/Kconfig                    | 15 +++++++
>>  arch/mips/generic/Platform                   |  2 +
>>  arch/mips/generic/board-epm5.its.S           | 24 +++++++++++
>>  4 files changed, 83 insertions(+)
>>  create mode 100644 arch/mips/configs/generic/board-eyeq5.config
>>  create mode 100644 arch/mips/generic/board-epm5.its.S
>>
>> diff --git a/arch/mips/configs/generic/board-eyeq5.config 
>> b/arch/mips/configs/generic/board-eyeq5.config
>> new file mode 100644
>> index 0000000000000..d94e408145389
>> --- /dev/null
>> +++ b/arch/mips/configs/generic/board-eyeq5.config
>> @@ -0,0 +1,42 @@
>> +CONFIG_HIGH_RES_TIMERS=y
>> +CONFIG_TASKSTATS=y
>> +CONFIG_FIT_IMAGE_FDT_EPM5=y
>> +CONFIG_BOARD_EYEQ5=y
>> +CONFIG_PHYSICAL_START=0xa800000808000000
>
> ^ I still think by doing this you are risking overriding starting address
> for all other generic systems. make 32r6_defconfig will load config files
> of all boards.

I think at a point you mentioned a way to remove the eyeq5 config board
from the 32r6_defconfig. It would be indeed a good solution.

>
> Perhaps just provide an eqm5_defconfig will work better?

So you mean a defconfig in direclty in arch/mips/configs/ and not
anymore in arch/mips/configs/generic ?

Gregory

>
> Thanks.
> -- 
> - Jiaxun

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com