linux-kernel - Re: [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <270eb954c25433da1ae24d2ce219f195e628fdf3.camel@mediatek.com>
Date: Fri, 15 Dec 2023 03:06:53 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: CK Hu (胡俊光) <ck.hu@...iatek.com>,
	"jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	Johnson Wang (王聖鑫) <Johnson.Wang@...iatek.com>,
	Jason-ch Chen (陳建豪)
	<Jason-ch.Chen@...iatek.com>, Shawn Sung (宋孝謙)
	<Shawn.Sung@...iatek.com>, Nancy Lin (林欣螢)
	<Nancy.Lin@...iatek.com>, "jkardatzke@...gle.com" <jkardatzke@...gle.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>
Subject: Re: [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188

Hi CK,

Thanks for the reviews.

On Fri, 2023-12-15 at 02:47 +0000, CK Hu (胡俊光) wrote:
> Hi, Jason:
> 
> On Fri, 2023-12-15 at 10:35 +0800, Jason-JH.Lin wrote:
> > Add CMDQ driver support for mt8188 by adding its compatible and
> > driver data in CMDQ driver.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> > ---
> >  drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> > b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 76e5f762628c..612b9feb258a 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -749,11 +749,19 @@ static const struct gce_plat gce_plat_v7 = {
> >  	.gce_num = 1
> >  };
> >  
> > +static const struct gce_plat gce_plat_v8 = {
> > +	.thread_nr = 32,
> > +	.shift = 3,
> > +	.control_by_sw = true,
> > +	.gce_num = 2
> > +};
> > +
> >  static const struct of_device_id cmdq_of_ids[] = {
> >  	{.compatible = "mediatek,mt6779-gce", .data = (void
> > *)&gce_plat_v4},
> >  	{.compatible = "mediatek,mt8173-gce", .data = (void
> > *)&gce_plat_v2},
> >  	{.compatible = "mediatek,mt8183-gce", .data = (void
> > *)&gce_plat_v3},
> >  	{.compatible = "mediatek,mt8186-gce", .data = (void
> > *)&gce_plat_v7},
> > +	{.compatible = "mediatek,mt8188-gce", .data = (void
> > *)&gce_plat_v8},
> 
> I think 'v8' is not trivial for anyone. Every SoC has each setting,
> so
> I would like the name to directly show the SoC name, such as
> 'gce_plat_mt8188'. So does other SoC.
> 

OK, I'll add a patch to modify gce_plat postfix from 'v1~v7' to the SoC
names. Then add 'gce_plat_mt8188' for mt8188.

Regards,
Jason-JH.Lin

> Regards,
> CK
> 
> >  	{.compatible = "mediatek,mt8192-gce", .data = (void
> > *)&gce_plat_v5},
> >  	{.compatible = "mediatek,mt8195-gce", .data = (void
> > *)&gce_plat_v6},
> >  	{}