linux-kernel - Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdo=g7ZBAuk79PtLOYs-YHo5sCTp1WVFESHA0xN0zGEmQ@mail.gmail.com>
Date: Fri, 15 Dec 2023 21:09:05 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: Andy Shevchenko <andy@...nel.org>, Kees Cook <keescook@...omium.org>, 
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Nick DeSaulniers <nnn@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, llvm@...ts.linux.dev, 
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

On Fri, Dec 15, 2023 at 8:31 PM Tanzir Hasan <tanzirh@...gle.com> wrote:
> On Fri, Dec 15, 2023 at 8:04 AM Andy Shevchenko <andy@...nel.org> wrote:
>> On Thu, Dec 14, 2023 at 09:06:12PM +0000, tanzirh@...gle.com wrote:

...

>> > +#include <linux/kernel.h>
>>
>> I highly discourage from doing that. Instead, split what is needed to
>> the separate (new) header and include that one.
>
>
> I think it would make the most sense to do this in a separate patch.
> What word-at-a-time.h needs from kernel.h is REPEAT_BYTE and to my knowledge,
> almost every other version of word-at-a-time.h includes kernel.h gets this by
> including kernel.h. A future change could be removing REPEAT_BYTE
> out of kernel.h

Just create a patch that either moves that macro (along with upper_*()
and lower_*() APIs) to a more distinguishable header
(maybe bytes.h or words.h or wordpart.h, etc) and use it in your case
and fix others.

-- 
With Best Regards,
Andy Shevchenko