linux-kernel - Re: [PATCH 2/3] x86/crash: use SZ_1M macro instead of hardcoded value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXvHx+HYI4zgV47b@MiWiFi-R3L-srv>
Date: Fri, 15 Dec 2023 11:28:07 +0800
From: Baoquan He <bhe@...hat.com>
To: Yuntao Wang <ytcoode@...il.com>
Cc: linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>, Vivek Goyal <vgoyal@...hat.com>,
	Dave Young <dyoung@...hat.com>,
	Hari Bathini <hbathini@...ux.ibm.com>,
	Eric DeVolder <eric.devolder@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sourabh Jain <sourabhjain@...ux.ibm.com>,
	Sean Christopherson <seanjc@...gle.com>,
	Takashi Iwai <tiwai@...e.de>, Lianbo Jiang <lijiang@...hat.com>
Subject: Re: [PATCH 2/3] x86/crash: use SZ_1M macro instead of hardcoded value

On 12/15/23 at 12:38am, Yuntao Wang wrote:
> Use SZ_1M macro instead of hardcoded 1<<20 to make code more readable.
> 
> Signed-off-by: Yuntao Wang <ytcoode@...il.com>
> ---
>  arch/x86/kernel/crash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index 792231a56d11..249b5876e7ec 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c

Acked-by: Baoquan He <bhe@...hat.com>

> @@ -170,7 +170,7 @@ static int elf_header_exclude_ranges(struct crash_mem *cmem)
>  	int ret = 0;
>  
>  	/* Exclude the low 1M because it is always reserved */
> -	ret = crash_exclude_mem_range(cmem, 0, (1<<20)-1);
> +	ret = crash_exclude_mem_range(cmem, 0, SZ_1M - 1);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.43.0
>