linux-kernel - Re: [PATCH] md/raid1: remove unnecessary null checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW5Oj67XR6EhndSXCkd52h8P4nAXipxrhG31fy7YNOZg6g@mail.gmail.com>
Date: Fri, 15 Dec 2023 15:31:04 -0800
From: Song Liu <song@...nel.org>
To: Gou Hao <gouhao@...ontech.com>
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, 
	gouhaojake@....com
Subject: Re: [PATCH] md/raid1: remove unnecessary null checking

On Thu, Dec 14, 2023 at 7:15 AM Gou Hao <gouhao@...ontech.com> wrote:
>
> If %__GFP_DIRECT_RECLAIM is set then bio_alloc_bioset will always
> be able to allocate a bio. See comment of bio_alloc_bioset.
>
> Signed-off-by: Gou Hao <gouhao@...ontech.com>

Applied to md-next. Thanks!

Song

> ---
>  drivers/md/raid1.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 35d12948e0a9..e77dc95d4a75 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1126,8 +1126,6 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,
>
>         behind_bio = bio_alloc_bioset(NULL, vcnt, 0, GFP_NOIO,
>                                       &r1_bio->mddev->bio_set);
> -       if (!behind_bio)
> -               return;
>
>         /* discard op, we don't support writezero/writesame yet */
>         if (!bio_has_data(bio)) {
> --
> 2.34.1
>
>