lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231215003812.29650-1-cw9316.lee@samsung.com> Date: Fri, 15 Dec 2023 09:38:12 +0900 From: Chanwoo Lee <cw9316.lee@...sung.com> To: agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org, mani@...nel.org, jejb@...ux.ibm.com, martin.petersen@...cle.com, quic_asutoshd@...cinc.com, dmitry.baryshkov@...aro.org, ahalaney@...hat.com, linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Cc: grant.jung@...sung.com, jt77.jang@...sung.com, dh0421.hwang@...sung.com, sh043.lee@...sung.com, ChanWoo Lee <cw9316.lee@...sung.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Subject: [PATCH v3] scsi: ufs: qcom: Return ufs_qcom_clk_scale_*() errors in ufs_qcom_clk_scale_notify() From: ChanWoo Lee <cw9316.lee@...sung.com> In commit 031312dbc695 ("scsi: ufs: ufs-qcom: Remove unnecessary goto statements") the error handling was accidentally changed, resulting in the error of ufs_qcom_clk_scale_*() calls not being returned. This is the case I checked. * ufs_qcom_clk_scale_notify -> 'ufs_qcom_clk_scale_up_/down_pre_change' error -> return 0; Let's make sure those errors are properly returned. Fixes: 031312dbc695 ("scsi: ufs: ufs-qcom: Remove unnecessary goto statements") Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com> --- * v2->v3: Change title and description v2 : https://patchwork.kernel.org/project/linux-scsi/patch/20231214021401.26474-1-cw9316.lee@samsung.com/ * v1->v2: Remove things already in progress v1 : https://patchwork.kernel.org/project/linux-scsi/patch/20231213022500.9011-1-cw9316.lee@samsung.com/ --- --- drivers/ufs/host/ufs-qcom.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 96cb8b5b4e66..17e24270477d 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1516,9 +1516,11 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba, err = ufs_qcom_clk_scale_up_pre_change(hba); else err = ufs_qcom_clk_scale_down_pre_change(hba); - if (err) - ufshcd_uic_hibern8_exit(hba); + if (err) { + ufshcd_uic_hibern8_exit(hba); + return err; + } } else { if (scale_up) err = ufs_qcom_clk_scale_up_post_change(hba); -- 2.29.0
Powered by blists - more mailing lists