[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66a211d8-de40-4827-9e84-b226545986c6@linaro.org>
Date: Fri, 15 Dec 2023 08:35:07 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ninad Palsule <ninad@...ux.ibm.com>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, joel@....id.au,
andrew@...econstruct.com.au, peterhuewe@....de, jarkko@...nel.org,
jgg@...pe.ca, keescook@...omium.org, tony.luck@...el.com,
gpiccoli@...lia.com, johannes.holland@...ineon.com, linux@...ck-us.net,
broonie@...nel.org
Cc: patrick.rudolph@...ements.com, vincent@...emblay.dev,
peteryin.openbmc@...il.com, lakshmiy@...ibm.com, bhelgaas@...gle.com,
naresh.solanki@...ements.com, alexander.stein@...tq-group.com,
festevam@...x.de, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
linux-hardening@...r.kernel.org, geissonator@...oo.com
Subject: Re: [PATCH v1 4/8] ARM: dts: aspeed: System1: Add i2c and muxes
On 14/12/2023 19:34, Ninad Palsule wrote:
>>> chosen {
>>> stdout-path = &uart5;
>>> bootargs = "console=ttyS4,115200n8 earlycon";
>>> @@ -54,10 +113,12 @@ vga_memory: region@...00000 {
>>> reg = <0xbf000000 0x01000000>; /* 16M */
>>> };
>>> };
>>> +
>> You need to clean your patchset...
> I made changes about the stdout-path, is that what you mean?
No, I meant you made irrelevant changes in this patch.
>>
>>
>>> };
>>>
>>> &adc1 {
>>> status = "okay";
>>> +
>> Really.
> I need to add "status = okay" otherwise its not instantiated.
That was about blank line. How is it related to this patch "Add i2c and
muxes"?
Best regards,
Krzysztof
Powered by blists - more mailing lists