linux-kernel - Re: [PATCH] mtd: rawnand: diskonchip: fix a potential double free in doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20231215105914.499203-1-miquel.raynal@bootlin.com>
Date: Fri, 15 Dec 2023 11:59:14 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Dinghao Liu <dinghao.liu@....edu.cn>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>,
	linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: diskonchip: fix a potential double free in doc_probe

On Thu, 2023-12-14 at 07:29:43 UTC, Dinghao Liu wrote:
> When nand_scan() fails, it has cleaned up related resources
> in its error paths. Therefore, the following nand_cleanup()
> may lead to a double-free. One possible trace is:
> 
> doc_probe
>   |-> nand_scan
>   |     |-> nand_scan_with_ids
>   |           |-> nand_scan_tail
>   |                 |-> kfree(chip->data_buf) [First free]
>   |
>   |-> nand_cleanup
>         |-> kfree(chip->data_buf) [Double free here]
> 
> Fix this by removing nand_cleanup() on failure of
> nand_scan().
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel