linux-kernel - Re: [PATCH] gpio: xilinx: remove excess kernel doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Dec 2023 12:08:58 +0100
From: Michal Simek <michal.simek@....com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
 Srinivas Neeli <srinivas.neeli@....com>, Andy Shevchenko <andy@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Marc Zyngier <maz@...nel.org>
Cc: linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] gpio: xilinx: remove excess kernel doc



On 12/15/23 10:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
> 
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>   drivers/gpio/gpio-xilinx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
>    * @dir: GPIO direction shadow register
>    * @gpio_lock: Lock used for synchronization
>    * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
>    * @enable: GPIO IRQ enable/disable bitfield
>    * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
>    * @falling_edge: GPIO IRQ falling edge enable/disable bitfield

Interesting because kernel-doc is not reporting any issue but issue is there.

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal