lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231215014248.6f7sqh6n4kmhe4js@zenone.zhora.eu> Date: Fri, 15 Dec 2023 02:42:48 +0100 From: Andi Shyti <andi.shyti@...nel.org> To: Quan Nguyen <quan@...amperecomputing.com> Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>, Wolfram Sang <wsa@...nel.org>, Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com>, Guenter Roeck <linux@...ck-us.net>, linux-i2c@...r.kernel.org, openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Cosmo Chou <chou.cosmo@...il.com>, Open Source Submission <patches@...erecomputing.com>, Phong Vo <phong@...amperecomputing.com>, "Thang Q . Nguyen" <thang@...amperecomputing.com> Subject: Re: [PATCH v4 1/2] i2c: aspeed: Handle the coalesced stop conditions with the start conditions. Hi Quan, On Mon, Dec 11, 2023 at 05:22:16PM +0700, Quan Nguyen wrote: > Some masters may drive the transfers with low enough latency between > the nak/stop phase of the current command and the start/address phase > of the following command that the interrupts are coalesced by the > time we process them. > Handle the stop conditions before processing SLAVE_MATCH to fix the > complaints that sometimes occur below. > > "aspeed-i2c-bus 1e78a040.i2c-bus: irq handled != irq. Expected > 0x00000086, but was 0x00000084" > > Fixes: f9eb91350bb2 ("i2c: aspeed: added slave support for Aspeed I2C driver") > Signed-off-by: Quan Nguyen <quan@...amperecomputing.com> > Reviewed-by: Andrew Jeffery <andrew@...econstruct.com.au> > Reviewed-by: Andi Shyti <andi.shyti@...nel.org> > --- > v4: > + Add an extra empty line before the comment [Andrew] > > Note: I'd like to keep adding Reviewed-by Andrew and Andi for this patch > eventhough there is an extra empty line added before the comment as mentioned > above. Thanks for the review. that's OK and you should. You would remove the r-b/a-b only if you do some major changes. Besides, this change was asked both by me and Andrew. Thanks, Andi
Powered by blists - more mailing lists