linux-kernel - Re: [PATCH] fs: remove duplicated including of posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOQ4uxhoYTtnwKX0k3GwORWzJaYAJwpxu9B-ONu5Y0gdkavo8g@mail.gmail.com>
Date: Fri, 15 Dec 2023 13:16:49 +0200
From: Amir Goldstein <amir73il@...il.com>
To: Wang Jinchao <wangjinchao@...sion.com>
Cc: Miklos Szeredi <miklos@...redi.hu>, linux-unionfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stone.xulei@...sion.com
Subject: Re: [PATCH] fs: remove duplicated including of posix_acl.h

On Fri, Dec 15, 2023 at 12:17 PM Wang Jinchao <wangjinchao@...sion.com> wrote:
>
> remove the second including of linux/posix_acl.h
>
> Signed-off-by: Wang Jinchao <wangjinchao@...sion.com>
> ---
>  fs/overlayfs/inode.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index c63b31a460be..2003425875d9 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -14,7 +14,6 @@
>  #include <linux/fileattr.h>
>  #include <linux/security.h>
>  #include <linux/namei.h>
> -#include <linux/posix_acl.h>
>  #include <linux/posix_acl_xattr.h>
>  #include "overlayfs.h"
>

Since both posix_acl.h and posix_acl_xattr.h are included by overlayfs.h
I would rather remove them both including the first posix_acl.h include.

It is far from being the only duplicate include in "overlayfs.h" and it is not
important enough IMO to start a cleanup project, but if you are going to
tidy up includes for a particular file, I'd rather use the opportunity to
cleanup that duplicity as well.

Thanks,
Amir.