linux-kernel - Re: (subset) [PATCH] drm/imagination: Fixed infinite loop in pvr_vm_mips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170264598213.449619.12866525083643261549.b4-ty@kernel.org>
Date: Fri, 15 Dec 2023 14:13:02 +0100
From: Maxime Ripard <mripard@...nel.org>
To: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
 Donald Robson <donald.robson@...tec.com>
Cc: frank.binns@...tec.com, matt.coster@...tec.com, 
 maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de, airlied@...il.com, 
 daniel@...ll.ch, Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: (subset) [PATCH] drm/imagination: Fixed infinite loop in
 pvr_vm_mips_map()

On Fri, 08 Dec 2023 16:08:25 +0000, Donald Robson wrote:
> Unwinding loop in error path for this function uses unsigned limit
> variable, causing the promotion of the signed counter variable.
> 
> --> 204         for (; pfn >= start_pfn; pfn--)
>                        ^^^^^^^^^^^^^^^^
> If start_pfn can be zero then this is an endless loop.  I've seen this
> code in other places as well.  This loop is slightly off as well.  It
> should decrement pfn on the first iteration.
> 
> [...]

Applied to drm/drm-misc (drm-misc-next-fixes).

Thanks!
Maxime