linux-kernel - Re: (subset) [PATCH 1/2] drm/imagination: Fix ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <170264598817.449619.12909620922259107900.b4-ty@kernel.org>
Date: Fri, 15 Dec 2023 14:13:08 +0100
From: Maxime Ripard <mripard@...nel.org>
To: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
 Donald Robson <donald.robson@...tec.com>
Cc: frank.binns@...tec.com, matt.coster@...tec.com, 
 maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de, airlied@...il.com, 
 daniel@...ll.ch, Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: (subset) [PATCH 1/2] drm/imagination: Fix ERR_PTR test on
 pointer to pointer.

On Wed, 13 Dec 2023 14:44:30 +0000, Donald Robson wrote:
> drivers/gpu/drm/imagination/pvr_vm.c:631 pvr_vm_create_context()
>   error: 'vm_ctx->mmu_ctx' dereferencing possible ERR_PTR()
> 
> 612         vm_ctx->mmu_ctx = pvr_mmu_context_create(pvr_dev);
> 613         err = PTR_ERR_OR_ZERO(&vm_ctx->mmu_ctx);
>                                       ^
> The address is never an error pointer so this will always return 0.
> Remove the ampersand.
> 
> [...]

Applied to drm/drm-misc (drm-misc-next-fixes).

Thanks!
Maxime