[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87fs03cyki.fsf@BL-laptop>
Date: Fri, 15 Dec 2023 15:47:25 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Marek BehĂșn <kabel@...nel.org>
Cc: Sjoerd Simons <sjoerd@...labora.com>, kernel@...labora.com, Andrew Lunn
<andrew@...n.ch>, Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Rob Herring <robh+dt@...nel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Moxtet bus fixes
Marek BehĂșn <kabel@...nel.org> writes:
> On Fri, 08 Dec 2023 15:51:20 +0100
> Gregory CLEMENT <gregory.clement@...tlin.com> wrote:
>
>> Hello Marek and Sjoerd,
>>
>> > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64:
>> > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two
>> > reasons:
>> > * The moxtet irq isn't marked as shared so the driver fails to load if
>> > the rtc driver gets set up first.
>> > * The dts change didn't set the IRQ type, so in case the rtc driver got
>> > probed first irq setup ended up wrong (rising instead of falling edge).
>> >
>> > On top of that the moxtet module isn't auto-loading due to a missing spi
>> > table
>> >
>> > Changes in v2:
>> > - Add cover letter
>> > - Add patch to set the irq type
>> >
>> > Sjoerd Simons (3):
>> > bus: moxtet: Mark the irq as shared
>> > bus: moxtet: Add spi device table
>> > arm64: dts: armada-3720-turris-mox: set irq type for RTC
>>
>> I only received the previous patch in my inbox, I plan to apply it. But
>> what about the 2 other patches ? Marek will you do a pull request with
>> these 2 patches or do you expect that I take them also ?
>>
>> Regards,
>>
>> Gregory
>
> Gregory, as of yet I've never done a pull request. If you are willing
> to take all 3 patches now, please do. In the future I would like to
OK I applied them on mvebu/driver.
> start doing it for Turris stuff, if you are OK with it.
No pb, just tell me when you are going to doing it.
Gregory
>
> Marek
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
Powered by blists - more mailing lists