linux-kernel - Re: [PATCH v1 1/1] pinctrl: intel: Add Intel Meteor Point pin controller and GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Dec 2023 16:58:24 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Raag Jadav <raag.jadav@...el.com>, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Add Intel Meteor Point pin
 controller and GPIO support

On Fri, Dec 15, 2023 at 04:42:31PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 15, 2023 at 08:44:17AM +0200, Mika Westerberg wrote:
> > On Thu, Dec 14, 2023 at 05:46:53PM +0200, Andy Shevchenko wrote:
> > > This driver supports pinctrl/GPIO hardware found on Intel Meteor Point
> > > (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces
> > > including GPIO interrupts.
> > 
> > This is driver for Meteor Lake-S and related, correct? Why it cannot use
> > pinctrl-meteorlake.c instead? Same way we do for other desktop CPUs
> > whose PCHs have the GPIO/pinctrl block.
> 
> Meteor Lake-S may or may not have an additional PCH, so the SoC (on-die)
> pin control IP is serviced by pinctrl-meteorlake.c, here we need to have
> a different file as we would have a name clash. Yes, it means that on
> the end user platform it may be two pin control drivers!

I see, thanks for clarification! Then this makes sense.

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>