linux-kernel - Re: [PATCH] Revert "soc: qcom: stats: Add DDR sleep stats"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7530d783-00e7-4196-b18f-3eb372df8325@linaro.org>
Date: Sat, 16 Dec 2023 14:07:38 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Bjorn Andersson <andersson@...nel.org>
Cc: Andy Gross <agross@...nel.org>, Arnd Bergmann <arnd@...nel.org>,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH] Revert "soc: qcom: stats: Add DDR sleep stats"

On 16.12.2023 05:35, Bjorn Andersson wrote:
> On Sat, Dec 16, 2023 at 01:05:53AM +0100, Konrad Dybcio wrote:
>> On 14.12.2023 13:25, Konrad Dybcio wrote:
>>> After recent reports ([1], [2]) of older platforms (particularly 8150 and
>>> 7180) breaking after DDR sleep stats introduction, revert the following:
>>>
>>> Commit 73380e2573c3 ("soc: qcom: stats: fix 64-bit division")
>>> Commit e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats")
>>>
>>> The feature itself is rather useful for debugging DRAM power management,
>>> however it looks like the shared RPMh stats data structures differ on
>>> previous SoCs.
>>>
>>> Revert its addition for now to un-break booting on these earlier SoCs,
>>> while I try to come up with a better way to enable it conditionally.
>>>
>>> [1] https://lore.kernel.org/linux-arm-msm/20231209215601.3543895-2-dmitry.baryshkov@linaro.org/
>>> [2] https://lore.kernel.org/linux-arm-msm/CAD=FV=XX4wLg1NNVL15RK4D4tLvuSzZyUv=k_tS4bSb3=7QJzQ@mail.gmail.com/
>>>
>>> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>> Reported-by: Doug Anderson <dianders@...omium.org>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>> ---
>> Arnd, since Bjorn seems to be MIA, could you please pick this directly
>> so that it gets into the next RC? Un-breaking booting on some platforms
>> would be very welcome :D
>>
> 
> I'm confused, the two offending commits are staged for v6.8. Which -rc
> do you want this applied in?! And you posted this patch yesterday...
Uh right, sorry, I should think twice before sending such emails late
into the night..

Konrad