linux-kernel - Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69178bc1-d682-4947-bfc5-bd3bb817e8aa@quicinc.com>
Date: Sat, 16 Dec 2023 21:23:26 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <robert.marko@...tura.hr>, <linux-arm-msm@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_srichara@...cinc.com>
Subject: Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332
 platform



On 12/15/2023 9:34 PM, Andrew Lunn wrote:
>> These properties "reset-assert-us" and "reset-deassert-us" are the
>> general properties from mdio.yaml, which are used when the MDIO
>> bus driver is registered by the MDIO framework.
>> The general DT property already supports to do the correct config,
>> then compatible string is not needed to be checked for doing the
>> configs.
> 
> Given the complexity of your device, i doubt you can make it work
> without using a compatible containing the ID register values. That
> will get your driver loaded, and the probe method called which can
> then deal with all the clocks and resets in whatever way it wants.
> 
>      Andrew
> 

I misunderstood Krzysztof's suggestion in the previous message, i
thought the reset properties configuration is checked according
to the compatible string in the drive code.

Yes, these properties can be deduced from the compatible string in
the DT doc, i will update this in the next patch set.

Thanks for the comments and suggestion.