linux-kernel - Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1d61da8-3aba-4d4a-a852-3e743666da11@lwfinger.net>
Date: Sat, 16 Dec 2023 12:35:29 -0600
From: Larry Finger <Larry.Finger@...inger.net>
To: Zenm Chen <zenmchen@...il.com>, Jes.Sorensen@...il.com
Cc: kvalo@...nel.org, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, pkshih@...ltek.com, rtl8821cerfe2@...il.com
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU
 devices

On 12/16/23 10:52, Zenm Chen wrote:
> Add additional USB IDs found in the vendor driver from
> https://github.com/Mange/rtl8192eu-linux-driver to support more
> RTL8192EU devices.
> 
> Signed-off-by: Zenm Chen <zenmchen@...il.com>
> ---
> v2:
>   - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED

Have you tested all modes including STA, AP, P2P, etc? If not, then your devices 
belong in the CONFIG_RTL8XXXU_UNTESTED section.

I am also not fond of splitting the rtl8192eu devices into several different 
spots in the table. That only makes it harder to see what devices are supported.

NACKed by Larry Finger <Larry.Finger@...inger.net>

Larry