linux-kernel - Re: [PATCH 26/50] rslib: kill bogus dependency on list.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65c68bf8-c577-4103-ae7e-7871ae276c22@infradead.org>
Date: Sat, 16 Dec 2023 11:10:03 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Kent Overstreet <kent.overstreet@...ux.dev>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 linux-fsdevel@...r.kernel.org
Cc: tglx@...utronix.de, x86@...nel.org, tj@...nel.org, peterz@...radead.org,
 mathieu.desnoyers@...icios.com, paulmck@...nel.org, keescook@...omium.org,
 dave.hansen@...ux.intel.com, mingo@...hat.com, will@...nel.org,
 longman@...hat.com, boqun.feng@...il.com, brauner@...nel.org
Subject: Re: [PATCH 26/50] rslib: kill bogus dependency on list.h



On 12/16/23 11:05, Randy Dunlap wrote:
> 
> 
> On 12/15/23 19:29, Kent Overstreet wrote:
>> list_head is defined in types.h, not list.h - this kills a sched.h
>> dependency.
>>
>> Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>
>> ---
>>  include/linux/rslib.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/rslib.h b/include/linux/rslib.h
>> index 238bb85243d3..a04dacbdc8ae 100644
>> --- a/include/linux/rslib.h
>> +++ b/include/linux/rslib.h
>> @@ -10,7 +10,6 @@
>>  #ifndef _RSLIB_H_
>>  #define _RSLIB_H_
>>  
>> -#include <linux/list.h>
>>  #include <linux/types.h>	/* for gfp_t */
>>  #include <linux/gfp.h>		/* for GFP_KERNEL */
>>  
> 
> What about line 47?
> 
>     47		struct list_head list;
> 

I see. :)
it's in types.h, not list.h, as you explained!


-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html