linux-kernel - Re: [PATCH v5 3/3] media: i2c: gc2145: Galaxy Core GC2145 sensor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZX38UnAvBn45+y0W@duo.ucw.cz>
Date: Sat, 16 Dec 2023 20:36:50 +0100
From: Pavel Machek <pavel@....cz>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Jacopo Mondi <jacopo.mondi@...asonboard.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Rob Herring <robh@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/3] media: i2c: gc2145: Galaxy Core GC2145 sensor
 support

Hi!

> Addition of support for the Galaxy Core GC2145 XVGA sensor.
> The sensor supports both DVP and CSI-2 interfaces however for
> the time being only CSI-2 is implemented.
> 
> Configurations are currently based on initialization scripts
> coming from Galaxy Core and so for that purpose only 3 static
> resolutions are supported:
>  - 640x480
>  - 1280x720
>  - 1600x1200

Also only limited subset of pixel formats is implemented? Would be
worth mentioning in the changelog, but perhaps comment at the start of
the file would be even better.

> +++ b/drivers/media/i2c/Kconfig
> @@ -50,6 +50,16 @@ config VIDEO_AR0521
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called ar0521.
>  
> +config VIDEO_GC2145
> +	select V4L2_CCI_I2C
> +	tristate "GalaxyCore GC2145 sensor support"
> +	help
> +	  This is a V4L2 sensor-level driver for GalaxyCore GC2145
> +	  2 Mpixel camera.

Normally tristate would go before select.

Reviewed-by: Pavel Machek <pavel@....cz>

(But you probably want to solve the problems reported by the build
bot).

Thanks and best regards,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)