linux-kernel - Re: PATCH [netfilter] Remove old case sensitive variants of lowercase .c and .h files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <n64s37qp-093s-705p-q1r4-no875n163o91@vanv.qr>
Date: Sat, 16 Dec 2023 21:13:14 +0100 (CET)
From: Jan Engelhardt <jengelh@...i.de>
To: Samuel Marks <samuelmarks@...il.com>
cc: Pablo Neira Ayuso <pablo@...filter.org>, 
    Jozsef Kadlecsik <kadlec@...filter.org>, Florian Westphal <fw@...len.de>, 
    netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
    linux-kernel@...r.kernel.org
Subject: Re: PATCH [netfilter] Remove old case sensitive variants of lowercase
 .c and .h files


On Saturday 2023-12-16 20:22, Samuel Marks wrote:

>`git clone` fails on case-insensitive file systems, e.g., on Windows,
>MSYS, Cygwin due to case sensitive files. All but one are in
>netfilter, and they seem to be old code that isn't necessary.
>
> include/uapi/linux/netfilter/xt_CONNMARK.h  |   7 -
> include/uapi/linux/netfilter/xt_DSCP.h      |  27 --
> include/uapi/linux/netfilter/xt_MARK.h      |   7 -
> include/uapi/linux/netfilter/xt_RATEEST.h   |  17 -
> include/uapi/linux/netfilter/xt_TCPMSS.h    |  13 -
> include/uapi/linux/netfilter_ipv4/ipt_ECN.h |  34 --
> include/uapi/linux/netfilter_ipv4/ipt_TTL.h |  24 --
> include/uapi/linux/netfilter_ipv6/ip6t_HL.h |  25 --
> net/netfilter/Makefile                      |   4 -
> net/netfilter/xt_DSCP.c                     | 161 ---------
> net/netfilter/xt_HL.c                       | 159 ---------
> net/netfilter/xt_RATEEST.c                  | 233 -------------
> net/netfilter/xt_TCPMSS.c                   | 345 --------------------
> 13 files changed, 1056 deletions(-)
> delete mode 100644 include/uapi/linux/netfilter/xt_CONNMARK.h
> delete mode 100644 include/uapi/linux/netfilter/xt_DSCP.h
> delete mode 100644 include/uapi/linux/netfilter/xt_MARK.h
> delete mode 100644 include/uapi/linux/netfilter/xt_RATEEST.h
> delete mode 100644 include/uapi/linux/netfilter/xt_TCPMSS.h
> delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> delete mode 100644 include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> delete mode 100644 net/netfilter/xt_DSCP.c
> delete mode 100644 net/netfilter/xt_HL.c
> delete mode 100644 net/netfilter/xt_RATEEST.c
> delete mode 100644 net/netfilter/xt_TCPMSS.c

Did you ever test this?

	iptables -t mangle -A PREROUTING -i xyz0 -p tcp --syn -j TCPMSS --set-mss 1440

will now fail.