lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ad6b7294-049b-475a-bd55-75f61d72d258@huawei.com>
Date: Sat, 16 Dec 2023 09:42:54 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
	<wangjie125@...wei.com>, <liuyonglong@...wei.com>, <lanhao@...wei.com>,
	<wangpeiyang1@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 net-next 1/3] net: hns3: add command queue trace for
 hns3


on 2023/12/15 5:04, Simon Horman wrote:
> On Thu, Dec 14, 2023 at 10:11:33PM +0800, Jijie Shao wrote:
>> From: Hao Lan <lanhao@...wei.com>
>> ...
>> @@ -470,10 +470,14 @@ static int hclge_comm_cmd_check_result(struct hclge_comm_hw *hw,
>>   int hclge_comm_cmd_send(struct hclge_comm_hw *hw, struct hclge_desc *desc,
>>   			int num)
>>   {
>> +	bool is_special = hclge_comm_is_special_opcode(desc->opcode);
>>   	struct hclge_comm_cmq_ring *csq = &hw->cmq.csq;
>>   	int ret;
>>   	int ntc;
> hclge_comm_is_special_opcode takes a u16 value as it's argument,
> but the type of desc->opcode is __le16. So perhaps this should be
> (completely untested!):
>
> 	struct hclge_comm_cmq_ring *csq = &hw->cmq.csq;
> 	bool is_special;
> 	...
>
> 	is_special = hclge_comm_is_special_opcode(le16_to_cpu(desc->opcode));
>
> Flagged by Sparse.

Thank you,
it will be fixed in v3

Jijie


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ