lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202312171701.xNkzdgdi-lkp@intel.com>
Date: Sun, 17 Dec 2023 17:42:18 +0800
From: kernel test robot <lkp@...el.com>
To: Michael Shych <michaelsh@...lanox.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Guenter Roeck <linux@...ck-us.net>
Subject: drivers/watchdog/mlx_wdt.c:53: warning: Function parameter or member
 'wdt_type' not described in 'mlxreg_wdt'

Hi Michael,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3b8a9b2e6809d281890dd0a1102dc14d2cd11caf
commit: c60923dd5feedc337b1450e3f4c6e19ffa305439 watchdog: mlx-wdt: introduce a watchdog driver for Mellanox systems.
date:   4 years, 10 months ago
config: x86_64-buildonly-randconfig-004-20230906 (https://download.01.org/0day-ci/archive/20231217/202312171701.xNkzdgdi-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231217/202312171701.xNkzdgdi-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312171701.xNkzdgdi-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/watchdog/mlx_wdt.c:53: warning: Function parameter or member 'wdt_type' not described in 'mlxreg_wdt'


vim +53 drivers/watchdog/mlx_wdt.c

    20	
    21	#define MLXREG_WDT_CLOCK_SCALE		1000
    22	#define MLXREG_WDT_MAX_TIMEOUT_TYPE1	32
    23	#define MLXREG_WDT_MAX_TIMEOUT_TYPE2	255
    24	#define MLXREG_WDT_MIN_TIMEOUT		1
    25	#define MLXREG_WDT_OPTIONS_BASE (WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE | \
    26					 WDIOF_SETTIMEOUT)
    27	
    28	/**
    29	 * struct mlxreg_wdt - wd private data:
    30	 *
    31	 * @wdd:	watchdog device;
    32	 * @device:	basic device;
    33	 * @pdata:	data received from platform driver;
    34	 * @regmap:	register map of parent device;
    35	 * @timeout:	defined timeout in sec.;
    36	 * @action_idx:	index for direct access to action register;
    37	 * @timeout_idx:index for direct access to TO register;
    38	 * @tleft_idx:	index for direct access to time left register;
    39	 * @ping_idx:	index for direct access to ping register;
    40	 * @reset_idx:	index for direct access to reset cause register;
    41	 * @wd_type:	watchdog HW type;
    42	 */
    43	struct mlxreg_wdt {
    44		struct watchdog_device wdd;
    45		struct mlxreg_core_platform_data *pdata;
    46		void *regmap;
    47		int action_idx;
    48		int timeout_idx;
    49		int tleft_idx;
    50		int ping_idx;
    51		int reset_idx;
    52		enum mlxreg_wdt_type wdt_type;
  > 53	};
    54	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ