linux-kernel - Re: [PATCH v4 6/15] iio: adc: ad7091r: Move chip init data to container struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231217144823.7d6f8473@jic23-huawei>
Date: Sun, 17 Dec 2023 14:48:23 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, apw@...onical.com,
 joe@...ches.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
 paul.cercueil@...log.com, Michael.Hennerich@...log.com, lars@...afoo.de,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 dan.carpenter@...aro.org, dlechner@...libre.com,
 marcelo.schmitt1@...il.com, oe-kbuild-all@...ts.linux.dev,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/15] iio: adc: ad7091r: Move chip init data to
 container struct

On Sun, 17 Dec 2023 21:04:50 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Marcelo,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on jic23-iio/togreg]
> [also build test ERROR on linus/master v6.7-rc5 next-20231215]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Marcelo-Schmitt/scripts-checkpatch-Add-__aligned-to-the-list-of-attribute-notes/20231217-055420
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link:    https://lore.kernel.org/r/9d1248860193b55e79640b2e64c21c66bd6645f9.1702746240.git.marcelo.schmitt1%40gmail.com
> patch subject: [PATCH v4 6/15] iio: adc: ad7091r: Move chip init data to container struct
> config: um-randconfig-r111-20231217 (https://download.01.org/0day-ci/archive/20231217/202312172006.b2fep1oG-lkp@intel.com/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231217/202312172006.b2fep1oG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312172006.b2fep1oG-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/iio/adc/ad7091r5.c:59:14: error: initializer element is not constant  
>      .irq_info = ad7091r5_chip_info_irq,
>                  ^~~~~~~~~~~~~~~~~~~~~~
>    drivers/iio/adc/ad7091r5.c:59:14: note: (near initialization for 'ad7091r5_init_info.irq_info')
>    drivers/iio/adc/ad7091r5.c:60:17: error: initializer element is not constant
>      .info_no_irq = ad7091r5_chip_info_noirq,
>                     ^~~~~~~~~~~~~~~~~~~~~~~~

You should use a pointer rather than assigning the whole structure.

>    drivers/iio/adc/ad7091r5.c:60:17: note: (near initialization for 'ad7091r5_init_info.info_no_irq')
> 
> 
> vim +59 drivers/iio/adc/ad7091r5.c
> 
>     57	
>     58	static struct ad7091r_init_info ad7091r5_init_info = {
>   > 59		.irq_info = ad7091r5_chip_info_irq,  
>     60		.info_no_irq = ad7091r5_chip_info_noirq,
>     61		.regmap_config = &ad7091r_regmap_config,
>     62		.init_adc_regmap = &ad7091r5_regmap_init
>     63	};
>     64	
>