linux-kernel - Re: [PATCH v5 2/7] dt-bindings: mtd: ubi-volume: allow UBI volumes to provide NVMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <170277617078.3635202.15310156602338483620.robh@kernel.org>
Date: Sat, 16 Dec 2023 19:22:50 -0600
From: Rob Herring <robh@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Richard Weinberger <richard@....at>, Miquel Raynal <miquel.raynal@...tlin.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Vignesh Raghavendra <vigneshr@...com>, Rafał Miłecki <rafal@...ecki.pl>, linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/7] dt-bindings: mtd: ubi-volume: allow UBI volumes
 to provide NVMEM


On Sun, 17 Dec 2023 00:09:41 +0000, Daniel Golle wrote:
> UBI volumes may be used to contain NVMEM bits, typically device MAC
> addresses or wireless radio calibration data.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---
>  .../devicetree/bindings/mtd/partitions/linux,ubi.yaml  | 10 ++++++++++
>  .../devicetree/bindings/mtd/partitions/ubi-volume.yaml |  5 +++++
>  2 files changed, 15 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/mtd/partitions/ubi-volume.yaml:34:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
./Documentation/devicetree/bindings/mtd/partitions/ubi-volume.yaml:37:5: [warning] wrong indentation: expected 6 but found 4 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/de0bd3647ed2560074aa3528716c203b8939fe1d.1702770711.git.daniel@makrotopia.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.