linux-kernel - Re: [PATCH v5 22/23] PM: EM: Add em_dev_compute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231217180316.rblvtqaxjvu5xedf@airbuntu>
Date: Sun, 17 Dec 2023 18:03:16 +0000
From: Qais Yousef <qyousef@...alina.io>
To: Dietmar Eggemann <dietmar.eggemann@....com>
Cc: Lukasz Luba <lukasz.luba@....com>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, rafael@...nel.org, rui.zhang@...el.com,
	amit.kucheria@...durent.com, amit.kachhap@...il.com,
	daniel.lezcano@...aro.org, viresh.kumar@...aro.org,
	len.brown@...el.com, pavel@....cz, mhiramat@...nel.org,
	wvw@...gle.com
Subject: Re: [PATCH v5 22/23] PM: EM: Add em_dev_compute_costs() as API for
 device drivers

On 12/12/23 19:50, Dietmar Eggemann wrote:
> On 29/11/2023 12:08, Lukasz Luba wrote:
> > The device drivers can modify EM at runtime by providing a new EM table.
> > The EM is used by the EAS and the em_perf_state::cost stores
> > pre-calculated value to avoid overhead. This patch provides the API for
> > device drivers to calculate the cost values properly (and not duplicate
> > the same code).
> 
> New interface w/o any users? Can we not remove this from this patch-set
> and introduce it with the first user(s)?

It's a chicken and egg problem. No interface, will not enable the new users to
appear too. So assuming the interface makes sense, I vote to keep it.

I lost brain power half way through the series and didn't review this properly
yet; but will continue looking later during the week.


Cheers

--
Qais Yousef