linux-kernel - Re: [PATCH v4 15/15] iio: adc: ad7091r: Allow users to configure device events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMknhBF92vcoHakYYP-7JeYhQtz2-5008XJUBFO11vXZPjsdJw@mail.gmail.com>
Date: Sun, 17 Dec 2023 18:10:34 -0600
From: David Lechner <dlechner@...libre.com>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc: apw@...onical.com, joe@...ches.com, dwaipayanray1@...il.com, 
	lukas.bulwahn@...il.com, paul.cercueil@...log.com, 
	Michael.Hennerich@...log.com, lars@...afoo.de, jic23@...nel.org, 
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	dan.carpenter@...aro.org, marcelo.schmitt1@...il.com, 
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 15/15] iio: adc: ad7091r: Allow users to configure
 device events

On Sun, Dec 17, 2023 at 5:58 PM David Lechner <dlechner@...libre.com> wrote:
>
> On Sat, Dec 16, 2023 at 11:52 AM Marcelo Schmitt
> <marcelo.schmitt@...log.com> wrote:
> >
> > Implement event configuration callbacks allowing users to read/write
> > event thresholds and enable/disable event generation.
> >
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>
> > ---
> > This is from a review suggestion David made on v3 [1].
> >
> > Is this the case for a Suggested-by tag?
> >
> > [1]: https://lore.kernel.org/linux-iio/CAMknhBFPbAqp4-AQdmbp+VRW-Ksk1PxaLCG+3n=Zk4gyStqhgw@mail.gmail.com/#t
> >
>
> I suppose it fits the definition of Suggested-by well enough and would
> be appreciated. Even more so on [PATCH v4 02/15] "iio: adc: ad7091r:
> Pass iio_dev to event handler".

And it seems like this should have the Fixes tag since this is fixing
a null pointer dereference. And the commit message should describe the
problem and that this as a fix, otherwise it sounds like we are just
adding a new feature here.