[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87plz3leym.fsf@minerva.mail-host-address-is-not-set>
Date: Mon, 18 Dec 2023 16:15:13 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Conor Dooley <conor@...nel.org>
Cc: linux-kernel@...r.kernel.org, Maxime Ripard <mripard@...nel.org>,
Jocelyn Falempe <jfalempe@...hat.com>, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org>, Geert Uytterhoeven
<geert@...ux-m68k.org>, Thomas Zimmermann <tzimmermann@...e.de>, Peter
Robinson <pbrobinson@...il.com>, Rob Herring <robh@...nel.org>, Conor
Dooley <conor+dt@...nel.org>, Daniel Vetter <daniel@...ll.ch>, David
Airlie <airlied@...il.com>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Rob Herring <robh+dt@...nel.org>,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers
Conor Dooley <conor@...nel.org> writes:
Hello Conor,
Thanks a lot for your feedback.
> On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote:
[...]
>> +
>> + - properties:
>> + width:
>> + default: 96
>> + height:
>> + default: 64
>
> diff --git a/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml b/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml
> index 8feee9eef0fd..ffc939c782eb 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml
> @@ -9,24 +9,24 @@ title: Solomon SSD133x OLED Display Controllers
> maintainers:
> - Javier Martinez Canillas <javierm@...hat.com>
>
> +allOf:
> + - $ref: solomon,ssd-common.yaml#
> +
> properties:
> compatible:
> enum:
> - solomon,ssd1331
>
> + width:
> + default: 96
> +
> + height:
> + default: 64
> +
> required:
> - compatible
> - reg
>
> -allOf:
> - - $ref: solomon,ssd-common.yaml#
> -
> - - properties:
> - width:
> - default: 96
> - height:
> - default: 64
> -
> unevaluatedProperties: false
>
> examples:
>
> The properties stuff doesn't need to be in the allOf. Although, I took
Ok.
> the opportunity to look at ssd-common.yaml. How do the height/width here
> differ from the vendor prefixed versions in that file?
Oh! That is an error in the schema that I introduced when adding the
binding for the SSD132x family in commit 2d23e7d6bacb ("dt-bindings:
display: Add SSD132x OLED controllers"), and I just copied it to this
binding as well making the same mistake...
I'll fix that with a preparatory patch to use "solomon,{width,height}"
everywhere in v3 and also include your suggested changes for this patch.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Powered by blists - more mailing lists