linux-kernel - RE: [PATCH 1/2] cdx: Enable COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5333D6B9944BABADA6961FA89D90A@BL1PR12MB5333.namprd12.prod.outlook.com>
Date: Mon, 18 Dec 2023 04:39:21 +0000
From: "Agarwal, Nikhil" <nikhil.agarwal@....com>
To: Rob Herring <robh@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Gupta, Nipun"
	<Nipun.Gupta@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Gangurde, Abhijit"
	<abhijit.gangurde@....com>
Subject: RE: [PATCH 1/2] cdx: Enable COMPILE_TEST



> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Tuesday, December 12, 2023 7:56 PM
> To: Agarwal, Nikhil <nikhil.agarwal@....com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Gupta, Nipun
> <Nipun.Gupta@....com>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/2] cdx: Enable COMPILE_TEST
> 
> On Mon, Dec 11, 2023 at 10:40 PM Agarwal, Nikhil
> <nikhil.agarwal@....com> wrote:
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@...nel.org>
> > > Sent: Thursday, December 7, 2023 10:01 PM
> > > To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Gupta, Nipun
> > > <Nipun.Gupta@....com>; Agarwal, Nikhil <nikhil.agarwal@....com>
> > > Cc: linux-kernel@...r.kernel.org
> > > Subject: [PATCH 1/2] cdx: Enable COMPILE_TEST
> > >
> > > There is no reason CDX needs to depend on ARM64 other than limiting
> > > visibility. So let's also enable building with COMPILE_TEST.
> > >
> > > The CONFIG_OF dependency is redundant as ARM64 always enables it and
> > > all the DT functions have empty stubs.
> > >
> > > Signed-off-by: Rob Herring <robh@...nel.org>
> > > ---
> > >  drivers/cdx/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig index
> > > a08958485e31..7cdb7c414453 100644
> > > --- a/drivers/cdx/Kconfig
> > > +++ b/drivers/cdx/Kconfig
> > > @@ -7,7 +7,7 @@
> > >
> > >  config CDX_BUS
> > >       bool "CDX Bus driver"
> > > -     depends on OF && ARM64
> > > +     depends on ARM64 || COMPILE_TEST
> > Hi Rob,
> >
> > There is a CDX MSI support patch
> > https://lore.kernel.org/lkml/20231116125609.245206-1-
> nipun.gupta@....c
> > om/ which is in review and is dependent on ARM64( msi_alloc_info_t
> > definition differs on x86). So, the COMPILE_TEST would break once the MSI
> changes are added.
> 
> An ifdef around 'scratchpad' should fix that. It is worthwhile to get all this to
> build on x86 allyesconfig builds at least because that is frequently built by the
> various CI systems. arm64 is getting there, but x86 is first for many.
> 
> Rob

Thanks for the suggestion, Rob. We will change the MSI patch accordingly.