linux-kernel - Re: [PATCH v1 11/39] mm/userfaultfd: page_add_file_rmap() -> folio_add_file_rmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdc00f4c-9c65-4a50-baa9-01c5d83b65c1@arm.com>
Date: Mon, 18 Dec 2023 15:59:45 +0000
From: Ryan Roberts <ryan.roberts@....com>
To: David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Hugh Dickins <hughd@...gle.com>, Yin Fengwei <fengwei.yin@...el.com>,
 Mike Kravetz <mike.kravetz@...cle.com>, Muchun Song <muchun.song@...ux.dev>,
 Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH v1 11/39] mm/userfaultfd: page_add_file_rmap() ->
 folio_add_file_rmap_pte()

On 11/12/2023 15:56, David Hildenbrand wrote:
> Let's convert mfill_atomic_install_pte().
> 
> Reviewed-by: Yin Fengwei <fengwei.yin@...el.com>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Ryan Roberts <ryan.roberts@....com>

> ---
>  mm/userfaultfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> index 9ec814e47e99..330a481a1654 100644
> --- a/mm/userfaultfd.c
> +++ b/mm/userfaultfd.c
> @@ -114,7 +114,7 @@ int mfill_atomic_install_pte(pmd_t *dst_pmd,
>  		/* Usually, cache pages are already added to LRU */
>  		if (newly_allocated)
>  			folio_add_lru(folio);
> -		page_add_file_rmap(page, dst_vma, false);
> +		folio_add_file_rmap_pte(folio, page, dst_vma);
>  	} else {
>  		page_add_new_anon_rmap(page, dst_vma, dst_addr);
>  		folio_add_lru_vma(folio, dst_vma);