linux-kernel - Re: [PATCH 2/6] dt-bindings: spi: stm32: add st,stm32mp25-spi compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 17:58:32 +0100
From: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
To: Alain Volmat <alain.volmat@...s.st.com>, Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>,
        Erwan Leray <erwan.leray@...s.st.com>
CC: Valentin Caron <valentin.caron@...s.st.com>, <linux-spi@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] dt-bindings: spi: stm32: add st,stm32mp25-spi
 compatible

On 12/18/23 16:57, Alain Volmat wrote:
> From: Valentin Caron <valentin.caron@...s.st.com>
> 
> Add st,stm32mp25-spi compatible in dt-bindings.  STM32MP25 spi is similar

Hi Alain,
In case you re-submit,
Nitpicking, extra space here could be removed    ^
Capital letters for SPI could also be used here             ^

Appart from that, you can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>

Best Regards,
Fabrice

> to the STM32H7 except for the following two points:
>   - Burst should not be enabled with the new DMA used on STM32MP25.
>   - STM32MP25 SPI8 has a limited feature set, it can only send words of
>     8 or 16 bits and with a maximum words number of 1024.
> 
> Signed-off-by: Valentin Caron <valentin.caron@...s.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
>  Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index 5754d603f34f..4bd9aeb81208 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -25,6 +25,7 @@ properties:
>        - st,stm32f4-spi
>        - st,stm32f7-spi
>        - st,stm32h7-spi
> +      - st,stm32mp25-spi
>  
>    reg:
>      maxItems: 1